Put all EM_JS/EM_ASM strings in a specific data section #13443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment with the name "em_js", strip it from the binary. Even in debug mode the names given to data segments by clang will always start with ".data." or ".rodata" so there is no risk of normal data ending up in a section with this name. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment with the name "em_js", strip it from the binary. Even in debug mode the names given to data segments by clang will always start with ".data." or ".rodata" so there is no risk of normal data ending up in a section with this name. See: emscripten-core/emscripten#13443
|
Is it worth working on an EM_JS-specific solution? That is, is there no solution for EM_JS and EM_ASM? |
Sure, I'm just doing it one step at a time. EM_JS is actually quite different to EM_ASM in that the strings don't actually need to have addresses in LLVM sense... so the solution we end up with might look different. But also I do think and EM_JS-only solution is better than nothing. |
|
This part of the change is really a no-brainer (IMHO). It doesn't actually do anything except group the EM_JS strings into a single data section. Even if we never get around to actually purging it on the binaryen side (which I totally think we will) I still think its good for debugging / understandably. |
|
Updated the comment to include plans to further investigate the EM_ASM situation. |
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 8, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 9, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 9, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 11, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 11, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 11, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 11, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 12, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Feb 12, 2021
If we find a data segment whose entire contents is EM_JS or EM_ASM strings then strip it from the binary. See: emscripten-core/emscripten#13443
sbc100
changed the title
This way, once binaryen has extracted that string data it can potentially remove the segment or at least zero it out. Fixes #9366
sbc100
force-pushed
the
em_js_data_section
branch
from
842309d to
510d924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, once binaryen has extracted that string data
it can potentially remove the segment or at least zero it
out.
Fixes #9366